templater: add generic templating, migrate config list as example
#3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This serves the role of the formatter in Mercurial, but the provided features are rather restricted compared to mercurial.formatter. That's because both implementation language "Rust" and jj's template language are statically typed. The current implementation works well for simple commands like "config list -T", but it might be not okay for "branch list -T". If we implement branch templating by using the generic mechanism, the commit summary part would have to be evaluated as a separate template: -T 'branch_name ++ target_commit_summary' (target_commit_summary: Template) instead of -T 'branch_name ++ commit_summary(target_commit)' (target_commit: Commit) where the branch template language is a superset of the commit template language.
It was Default just because the implementation could be derived at that point. Using Default no longer makes sense.
There's a caveat: "jj config list -Tname" will concatenate all names in a single line. That's correct but useless. We might want some option or config knob to complete missing "\n". This also applies to "log --no-graph".
torquestomp
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md