commit_templater: make various attributes accessible to extensions #3213
Conversation
If the cache doesn't have to be shared between methods, it could be baked into a property closure. (e.g. |
In our case it would need to be shared between methods so capturing wouldn't be sufficient. I'll try rolling something simple to handle this then, it might be useful for revamping the revset extensions PR too. |
| @@ -121,6 +121,18 @@ impl<'repo> TemplateLanguage<'repo> for CommitTemplateLanguage<'repo> { | |||
| // If we need to add multiple languages that support Commit types, this can be | |||
| // turned into a trait which extends TemplateLanguage. | |||
| impl<'repo> CommitTemplateLanguage<'repo> { | |||
| pub fn repo(&self) -> &dyn Repo { | |||
There was a problem hiding this comment.
maybe 'repo lifetime is missing here. (didn't notice before, sorry.)
Fyi, the generic templater uses this approach (because it seemed useful for ad-hoc templating.) |
Ideally I also want to make the caching functionality extensible here, but I'm not sure of a good way to go about that yet. I really want some sort of thread-safe
HashMap<TypeId, Box<dyn Any (of TypeId)>>that can hold arbitrary cache objects in it but I don't know if that exists.Checklist
If applicable:
CHANGELOG.md