Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git init, git clone: add revset alias for trunk() #3205

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

bnjmnt4n
Copy link
Member

@bnjmnt4n bnjmnt4n commented Mar 4, 2024

Closes #2943.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • [NA] I have updated the documentation (README.md, docs/, demos/)
  • [NA] I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@bnjmnt4n
Copy link
Member Author

Closing this due to the rationale explained here: #2943 (comment).

@bnjmnt4n bnjmnt4n closed this Mar 17, 2024
@bnjmnt4n bnjmnt4n deleted the push-syolynqvlwsl branch March 17, 2024 06:58
@bnjmnt4n bnjmnt4n restored the push-syolynqvlwsl branch March 17, 2024 18:56
@bnjmnt4n bnjmnt4n reopened this Mar 18, 2024
@bnjmnt4n bnjmnt4n force-pushed the push-syolynqvlwsl branch from 4d3bb25 to f796a75 Compare June 1, 2024 14:27
@bnjmnt4n bnjmnt4n changed the title git: Add revset alias for trunk() on git clone git init, git clone: add revset alias for trunk() Jun 1, 2024
@bnjmnt4n bnjmnt4n marked this pull request as ready for review June 1, 2024 14:30
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cli/src/commands/git.rs Outdated Show resolved Hide resolved
cli/src/commands/git.rs Outdated Show resolved Hide resolved
cli/src/commands/git.rs Outdated Show resolved Hide resolved
cli/src/commands/git.rs Outdated Show resolved Hide resolved
cli/src/commands/git.rs Outdated Show resolved Hide resolved
cli/src/commands/git.rs Outdated Show resolved Hide resolved
@martinvonz
Copy link
Member

As I said on Discord, I hope this is ready for review. The discussion on #2943 doesn't seem to indicate that we don't want this PR. I think I just forgot about it. Sorry!

@bnjmnt4n bnjmnt4n force-pushed the push-syolynqvlwsl branch 2 times, most recently from 0283142 to 06445ab Compare June 14, 2024 13:20
cli/src/commands/git.rs Outdated Show resolved Hide resolved
cli/src/commands/git.rs Outdated Show resolved Hide resolved
cli/src/commands/git.rs Outdated Show resolved Hide resolved
cli/tests/test_git_clone.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the push-syolynqvlwsl branch 2 times, most recently from 74ee498 to 44df2d4 Compare June 14, 2024 22:06
@bnjmnt4n bnjmnt4n force-pushed the push-syolynqvlwsl branch from 44df2d4 to bec6d08 Compare July 3, 2024 16:16
@bnjmnt4n bnjmnt4n force-pushed the push-syolynqvlwsl branch from bec6d08 to 15399cb Compare July 4, 2024 08:57
@bnjmnt4n
Copy link
Member Author

bnjmnt4n commented Jul 4, 2024

Had to rebase this since the file structure changed since the last review. I will merge this in a while since it's already been approved.

@bnjmnt4n bnjmnt4n merged commit 0c0e001 into jj-vcs:main Jul 4, 2024
17 checks passed
@bnjmnt4n bnjmnt4n deleted the push-syolynqvlwsl branch July 4, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: add a revset function for the default branch of a remote
3 participants