Adjust visibility of codependent MutableRepo and CommitBuilder functions #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MutableRepo and CommitBuilder both define public (now crate-public) functions which should only be called by each other. This commit adds documentation and restricts visibility of these functions to the jj_lib crate. It might be even better to move CommitBuilder to the same module as MutableRepo so that these codependent functions can be private to the module to avoid misuse.
yuja
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MutableRepo and CommitBuilder both define public (now crate-public) functions which should only be called by each other. This commit adds documentation and restricts visibility of these functions to the jj_lib crate. It might be even better to move CommitBuilder to the same module as MutableRepo so that these co-dependent functions can be private to the module to avoid misuse.