Clean up the UnpublishedOperation struct #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
reviewed
Mar 2, 2024
emesterhazy
force-pushed
the
push-vqzvxzsozyol
branch
3 times, most recently
from
1bb1732 to
d9b0317
Compare
The custom Drop impl prevents us from moving members of UnpublishedOperation, and is the reason why `NewRepoData` is wrapped in an `Option`. We don't use custom Drop functions like this for debugging elsewhere in the codebase, and in some ways #[must_use] provides better protection since it will typically cause a compiler error if the UnpublishedOperation isn't used.
The Option is unnecessary now since `UnpublishedOperation` doesn't implement the Drop trait (the `MustClose` member implements it instead).
`NewRepoData` is just a container that holds data used to construct a `ReadonlyRepo`. The `ReaonlyRepo` is always constructed before the `UnpublishedOperation` is dropped, so we can simply construct the `ReadonlyRepo` upfront and delete the `NewRepoData` type.
emesterhazy
force-pushed
the
push-vqzvxzsozyol
branch
from
d9b0317 to
b6439c9
Compare
The only thing we need from the `RepoLoader` is the `OpHeadsStore`, so we can extract it in UnpublishedOperation::new instead of keeping the entire `RepoLoader` around.
emesterhazy
force-pushed
the
push-vqzvxzsozyol
branch
from
b6439c9 to
7f0397b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few minor refactoring changes to
UnpublishedOperation. The behavior is left unchanged.Happy to split this into separate PRs if that's easier, but these three commits together complete the cleanup.