Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add guidance for handling CRLF on Windows #3137

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

jennings
Copy link
Contributor

Attempts to add prescriptive guidance for dealing with LF line endings on Windows.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Copy link
Contributor

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

docs/windows.md Outdated Show resolved Hide resolved
@jennings jennings enabled auto-merge (rebase) February 26, 2024 18:00
@jennings jennings merged commit 6e29abb into jj-vcs:main Feb 26, 2024
15 checks passed
@jennings jennings deleted the push-rpnqtnmtptkt branch February 29, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants