nix: fix build on macOS #3136
Merged
nix: fix build on macOS #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This naming is just more consistent with the surrounding code. Signed-off-by: Austin Seipp <[email protected]>
When the `jj-proc-macros` crate was introduced, it triggered an underlying bug in `nextest`, which is the test harness we use in the Nix build. This is upstream Nextest bug 267. The long and short of it is that `rustc` fails to find needed libraries whenever the proc macros are loaded. This can easily be worked around however, by setting `DYLD_FALLBACK_LIBRARY_PATH` to an appropriate value in the devShell and in the `preCheck` phase of the main expression. Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-yvssuxnmunyo
branch
from
176b462 to
38df4ce
Compare
The aarch64-darwin macOS runners are actually quite speedy, often the fastest builders anyway. With the recent improvements to the Nix CI speed in 3f7b5a7, this shouldn't be a bottleneck, and will catch build regressions.
thoughtpolice
force-pushed
the
aseipp/push-yvssuxnmunyo
branch
from
38df4ce to
a4321d8
Compare
Ralith
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jj-proc-macroscrate caused the nix-on-macOS build to regress, due to nextest-rs/nextest#267. Work around this, and add nix-on-macOS to the CI matrix.Closes #3161.