templater: translate keywords to "self" methods by core template engine #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do clone Operation object in several places, and I'm going to add one more .clone() in the templater. Since the underlying metadata has many fields, I think it's better to wrap it with Arc just like a Commit object.
This is copied from the commit templater. I'm going to extract the "self" property handling to the core template builder, and build_keyword() methods will be replaced with that.
There are no keywords or methods that return Operation yet, but we might add "self" keyword that returns the context object.
Prepares for the removal of build_keyword().
This eliminates the separate keywords table. All keywords are resolved through the pseudo "self" property. Maybe we'll add "self" keyword/variable later.
torquestomp
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md