-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: list new remote branches during git fetch #3044
Conversation
I'm not sure what to do with these tests. They are designed to expect no stdout in the event of an error. I can address this issue, but I'm unsure if I should. |
Perhaps, the output can be written to stderr. It's kind of a status message. |
455de02
to
9115a1f
Compare
I hadn't noticed that 'Abandoned commits' were already being written to stderr. With these changes, all tests now pass. |
9115a1f
to
6589310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
9a97a3f
to
f30144a
Compare
f6dec62
to
62e593f
Compare
I'm not sure what to do with reference names that are too long. For now, padding is limited to 40 characters; perhaps we should consider using some kind of ellipsis |
62e593f
to
73e3ebb
Compare
Seems fine for now. Padding to accommodate the longer name also seems fine. |
73e3ebb
to
f8eaf0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, thanks!
f8eaf0e
to
8e4d1c7
Compare
8e4d1c7
to
a5ee83b
Compare
@yuja, I've implemented all the suggested changes, and it looks like the PR has received your approval. Unless there are any further comments or adjustments needed, may I proceed with merging it? Thank you for your guidance! |
Adds imported branches list for git fetch.
Checklist
If applicable:
CHANGELOG.md