Drop support for legacy graph drawing, add support for synthetic nodes for elided revisions #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
force-pushed
the
push-ltrzrlomyqpy
branch
2 times, most recently
from
00cb12d to
ada6b5b
Compare
martinvonz
force-pushed
the
push-ltrzrlomyqpy
branch
from
ada6b5b to
4ad0ea7
Compare
martinvonz
force-pushed
the
push-ltrzrlomyqpy
branch
from
4ad0ea7 to
ec972b9
Compare
The "curved" style has been the default for a long time now.
I don't think anyone uses the legacy graph style. It's very similar to the "ascii" style from Sapling's `renderdag` crate.
This adds a config to render a synthetic node with a "(elided revisions)" description for elided segments of the graph. I didn't add any templating support for the elided nodes because I'm not sure how we would want that to work. In particular, I don't know what `commit_id` and most other keywords should return for elided revisions.
martinvonz
force-pushed
the
push-ltrzrlomyqpy
branch
from
ec972b9 to
d83bca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope to enable this by default, so please enable it and see how you like it
Checklist
If applicable:
CHANGELOG.md