cli: inform the user of the command which disables the hint #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrittain
force-pushed
the
disable-diff-editor-msg
branch
from
41b2e21 to
f3b6ed2
Compare
|
This is in the same style as the |
benbrittain
force-pushed
the
disable-diff-editor-msg
branch
from
f3b6ed2 to
68c122e
Compare
martinvonz
reviewed
Feb 10, 2024
benbrittain
force-pushed
the
disable-diff-editor-msg
branch
2 times, most recently
from
d573eec to
db116a0
Compare
martinvonz
approved these changes
Feb 10, 2024
benbrittain
force-pushed
the
disable-diff-editor-msg
branch
from
db116a0 to
7591086
Compare
arxanas
reviewed
Feb 11, 2024
| @@ -175,7 +175,8 @@ fn editor_args_from_settings( | |||
| let default_editor = BUILTIN_EDITOR_NAME; | |||
| writeln!( | |||
| ui.hint(), | |||
| "Using default editor '{default_editor}'; you can change this by setting {key}" | |||
| "Using default editor '{default_editor}'; run `jj config set --user {key} :builtin` \ | |||
There was a problem hiding this comment.
The string should probably interpolate BUILTIN_EDITOR_NAME as well :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md