Update strsim (changes tests), clap, clap_complete #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is jj-vcs#3002 with tests rerun to account for changes to `strsim`, as @thoughtpolice noticed in jj-vcs#3002 (comment) The string similarity changes include an example that seems better and one that seems worse. Decreasing the threshold definitely makes things worse.
yuja
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #3002 with tests rerun to account for changes to
strsim, as @thoughtpolice noticed in#3002 (comment)
The string similarity changes include an example that
seems better and one that seems worse. Decreasing
the threshold definitely makes things worse.
Note: I'm turning automerge on.