lib refs.rs: rename TrackingRefPair to LocalAndRemoteRef
#2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
approved these changes
Feb 7, 2024
As discussed in jj-vcs#2962 (comment), the previous name is confusing since the struct is used for pairs where the remote branch is not tracked by the local branch.
ilyagr
force-pushed
the
tracking-ref-pair
branch
from
083a82a to
4307878
Compare
thoughtpolice
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in
#2962 (comment), the previous name is confusing since the struct is used for pairs where the remote branch is not tracked by the local branch.
Another name I considered was just
RefPair. If you don't like either, we could keep it as is for now.