Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixup to b318b200, mark code blocks in help as text #2897

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Jan 30, 2024

This prevents rust doctests from trying to compile the code blocks.

I don't think we use doctests much or at all, but I'd like cargo insta test --test-runner nextest --accept --workspace to pass.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr ilyagr force-pushed the fixup branch 2 times, most recently from 212172a to c91d982 Compare January 30, 2024 23:17
@ilyagr ilyagr marked this pull request as ready for review January 30, 2024 23:17
@ilyagr ilyagr changed the title docs: fixup to b318b2, mark code blocks as text docs: fixup to b318b200, mark code blocks as text Jan 30, 2024
This prevents rust doctests from trying to compile the code blocks.

I don't think we use doctests much or at all, but I'd like
`cargo insta test --test-runner nextest --accept --workspace`
to pass.

Unfortunately, this affects the output of `jj help` as well, but I
can't think of a workaround for that.
@ilyagr ilyagr changed the title docs: fixup to b318b200, mark code blocks as text docs: fixup to b318b200, mark code blocks in help as text Jan 30, 2024
@ilyagr
Copy link
Contributor Author

ilyagr commented Jan 30, 2024

Thanks!

Again, I'll merge this rather quickly so that people see fewer confusing errors, but we can change this later if needed/wanted.

@ilyagr ilyagr merged commit 96d0e77 into jj-vcs:main Jan 30, 2024
15 checks passed
@ilyagr ilyagr deleted the fixup branch January 30, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants