-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparse-v2: design doc proposition for Sparse Patterns refactoring #2877
Conversation
220e5eb
to
dfed901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some initial comments. I'd also prefer if you structured it like one of the existing Design Docs, maybe the style of tracking-branches fits for this document. Oh and don't forget to add it to mkdocs.yml
or it won't be in the design section of the website.
125841e
to
1e62edb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually really like the design from the first revision on, it just really lacks context for a broader (non-Google3) audience.
Maybe you could compare to Subversion's "externals" or https://github.com/josh-project/josh? |
1e62edb
to
1ae7176
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it's probably just missing a related work section. I'm going to leave the rest of the discussion in concerns to internal details to the respective stakeholders.
Thanks for the review! Sorry for harping on any previously-discussed points; there was a lot to read through. |
Added the josh project to "related work"; I don't think Subversion's "externals" are related here. |
Added a "Related Work" section. |
Kicks off work on issue #1896
1ae7176
to
a77433e
Compare
Proposal for a Sparse Patterns rewrite, to address multiple feature gaps.
Looking for feedback and approval before moving forward with real changes.
Checklist
If applicable:
CHANGELOG.md