cli_util: make running an editor on a tempfile easier #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
reviewed
Jan 22, 2024
yuja
reviewed
Jan 23, 2024
martinvonz
reviewed
Jan 23, 2024
Consolidates bulky tempfile code in sparse.rs and description_util.rs into cli_util.rs
torquestomp
force-pushed
the
dploch/edit-temp-file
branch
from
2059fb0 to
18ac9d5
Compare
yuja
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates a bunch of boilerplate io+tempfile code used in sparse.rs and description_util.rs into cli_util.rs, making the two call sites much simpler. This makes it easier for future callers to invoke the workflow of 'have the user edit this arbitrary string' without going through extra setup.
Checklist
If applicable:
CHANGELOG.md