cli: move some git utilities to new crate::git_utils
#2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit also needs to be able to push low-level refs into upstream remotes, just like `jj git push` does. Doing so requires providing callbacks e.g. for various password entry mechanisms, which was private to the `git` command module. Pull these out to a new module `git_utils` so we can reuse it across the two call sites. This also moves a few other strictly Git-related functions into `git_utils` as well, just for the sake of consistency. Signed-off-by: Austin Seipp <[email protected]>
martinvonz
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gerrit also needs to be able to push low-level refs into upstream remotes, just like
jj git pushdoes. Doing so requires providing callbacks e.g. for various password entry mechanisms, which was private to thegitcommand module.Pull these out to a new module
git_utilsso we can reuse it across the two call sites.This also moves a few other strictly Git-related functions into
git_utilsas well, just for the sake of consistency.Note: This was cut out of #2845 to keep the review smaller and also because it's largely procedural and simple.