Improve prompt support in JJ #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torquestomp
force-pushed
the
push-vxvrvssympvt
branch
from
3405d47 to
079a0c2
Compare
PhilipMetzger
approved these changes
Jan 19, 2024
yuja
approved these changes
Jan 20, 2024
|
Idle thought (for future PRs maybe): I was thinking of trying something like https://github.com/console-rs/dialoguer for this, which might allow a nicer UI for a selection list. A simpler version is almost certainly better at first, though, and who knows how polished that library actually is. |
torquestomp
force-pushed
the
push-vxvrvssympvt
branch
from
3bbac73 to
a636ef8
Compare
martinvonz
reviewed
Jan 22, 2024
Prompts are barely used in the CLI currently but they are very useful in extensions with more complex workflows.
Resolves part of issue jj-vcs#2126
torquestomp
force-pushed
the
push-vxvrvssympvt
branch
from
9fcbecb to
a3b6888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ui.prompt...()functions and uses them to fix issue #2126Checklist
If applicable:
CHANGELOG.md