Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object_id: don't allow ObjectId::from_hex() a dynamically allocated string #2780

Merged
merged 1 commit into from
Jan 5, 2024
Merged

object_id: don't allow ObjectId::from_hex() a dynamically allocated string #2780

merged 1 commit into from
Jan 5, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Jan 5, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@yuja
object_id: don't allow ObjectId::from_hex() a dynamically allocated s…
f3327f2 
…tring

This isn't technically needed, but it prevents API misuse. Another option
is to do some compile-time substitution, but most callers are tests and the
runtime performance wouldn't matter.
@yuja yuja enabled auto-merge (rebase) January 5, 2024 14:50
@yuja yuja merged commit a6616e9 into jj-vcs:main Jan 5, 2024
15 checks passed
@yuja yuja deleted the push-kyvyzpvwxqwz branch January 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz