Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ: Describe how to integrate with Gerrit. #2753

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

PhilipMetzger
Copy link
Contributor

@PhilipMetzger PhilipMetzger commented Dec 28, 2023

This question is mildly popular on Discord so it's finally time to have an answer.

We should do something better in the future but the current solution is good enough for today.

cc @thoughtpolice

Checklist

If applicable:

  • I have updated the documentation (README.md, docs/, demos/)

@PhilipMetzger PhilipMetzger force-pushed the push-oyvxvwtlxlkz branch 2 times, most recently from cbfeda8 to fb616e4 Compare December 28, 2023 19:14
@PhilipMetzger PhilipMetzger enabled auto-merge (rebase) December 28, 2023 19:19
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one quibble: I think just having the simple sentence saying "do git push to the gerrit ref after that" is enough. I'm neutral on adding signoff.sh here.

docs/FAQ.md Show resolved Hide resolved
docs/FAQ.md Show resolved Hide resolved
This question is mildly popular on Discord so it's finally time to have an answer.

We should do something better in the future but the current solution is good enough for today.

cc @thoughtpolice
@PhilipMetzger PhilipMetzger added the documentation Improvements or additions to documentation label Jan 1, 2024
@PhilipMetzger PhilipMetzger merged commit c2973fd into main Jan 1, 2024
15 checks passed
@PhilipMetzger PhilipMetzger deleted the push-oyvxvwtlxlkz branch January 1, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants