on "debug reindex" failed, report operation id containing missing commits #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed typo, s/a/an/.
…ding The error types are shared with the commit store backend. We could add per-store error types, but it's unlikely that the caller needs to discriminate them.
I'm going to add a public method that rebuilds index, and its return type will be different. I also added "build_" because "index" could be misinterpreted as noun. The method arguments are reordered to follow the public IndexStore interface.
My jj repo contains such head commits, and "jj debug reindex" fails. To address this problem, we'll probably need to implement GC, and the user will discard operations before the first bad op id.
martinvonz
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md