cli: use cwd-relative workspace config to resolve default command and aliases #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to load command aliases from .jj/repo/config.toml, WorkspaceLoader will be changed to be instantiated earlier with the cwd path.
It should be better to handle invalid -R path globally. The error message is a bit worse, but I think it's still okay. This helps to load temporary config from the cwd-relative path. If the command processing continued with an invalid -R path, the temporary config would have to be explicitly discarded.
… aliases This is basically the same as Mercurial's workaround. I don't know about Git, but arguments order is very restricted in git, so -C path can be parsed prior to alias expansion. In hg and jj, doing that would be messy and unreliable. Closes jj-vcs#2414
yuja
force-pushed
the
push-pupvwktoxyzx
branch
from
f70520f to
6c6e920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2414
Checklist
If applicable:
CHANGELOG.md