index: refactor maybe_squash_with_ancestors() #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think "for" loop is easier to follow. Maybe it could be rewritten further to .find_map() loop, but that would be too clever. I also made ancestor_index_segments() pub(super) since it doesn't make sense to only provide ancestor_files_without_local().
There are many unit tests that call mutable_segment.save_in(), but I don't think these callers expect that the segment file could be squashed depending on the size. Let's make it caller's responsibility. maybe_squash_with_ancestors() should be cheap if segment_num_commits() == 0, so it's okay to call it before checking the emptiness.
martinvonz
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md