index: propagate some of index load errors #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to remove .unwrap()s from DefaultIndexStore.
I thought IndexLoadError and DefaultIndexStoreError would represent "load" and "store" failures respectively, but they aren't. Actually, DefaultIndexStoreError is the store-level error, and IndexLoadError should be wrapped in it.
The idea is that we don't have to reload parent files as we already have the chain of the parent segments. The resulting readonly index will be constructed from the loaded parent segments + local entries blob.
This should be cheaper, and more importantly, we no longer need to propagate ReadonlyIndexLoadError to the caller.
martinvonz
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md