file_util: don't try to overwrite existing content-addressed file on Windows #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PersistError is basically a pair of io::Error and NamedTempFile instance. It's unlikely that we would want to propagate the open file instance to the CLI error handler, leaving the temporary file alive.
…Windows The doc says persist() replaces the destination file as rename() would do on Unix. persist_noclobber() doesn't, and is probably more reliable on Windows. I don't know if persist() is completely atomic on Windows, but if it isn't, it might be the source of the "permission denied" error under highly contended situation. https://docs.rs/tempfile/latest/tempfile/struct.NamedTempFile.html#method.persist https://github.com/Stebalien/tempfile/blob/v3.8.0/src/file/imp/windows.rs#L77 We could use persist_noclobber() on all platforms, but it's more involved on Unix. https://github.com/Stebalien/tempfile/blob/v3.8.0/src/file/imp/unix.rs#L107
For the same reason as the file_util change.
martinvonz
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md