Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index: use loaded readonly data without splitting into vecs #2696

Merged
merged 1 commit into from
Dec 13, 2023
Merged

index: use loaded readonly data without splitting into vecs #2696

merged 1 commit into from
Dec 13, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Dec 13, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@yuja
index: use loaded readonly data without splitting into vecs
c1a4c24 
Since lookup data isn't typically small, .split_off() can take a few
milliseconds to memcpy().
@yuja yuja merged commit 95a0cce into jj-vcs:main Dec 13, 2023
15 checks passed
@yuja yuja deleted the push-zyslmvnpotro branch December 13, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz