Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass transaction description at end, not beginning #2694

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Pass transaction description at end, not beginning #2694

merged 3 commits into from
Dec 13, 2023

Conversation

martinvonz
Copy link
Member

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@martinvonz
transaction: take description at end instead of start
03f7bb5 
It seems better to have the caller pass the transaction description
when we finish the transaction than when we start it. That way we have
all the information we want to include more readily available.
@martinvonz
cli: move a few transaction description variables later
8d975d9 
Now that we don't need the transaction until later, let's move the
variables closer to where they're used.
@martinvonz
Copy link
Member Author

I initially broke a test with my changes to commands/workspace.rs because I had failed to notice that the calculation of the transaction description had side effects. I've fixed that and put it in a separate commit at the end.

yuja
yuja approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

cli/src/commands/workspace.rs Outdated Show resolved Hide resolved
@martinvonz martinvonz enabled auto-merge (rebase) December 13, 2023 16:03
@martinvonz martinvonz merged commit 90e241c into main Dec 13, 2023
15 checks passed
@martinvonz martinvonz deleted the push-nqwwutpmwpps branch December 13, 2023 16:12
@martinvonz martinvonz mentioned this pull request Dec 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinvonz @yuja