index: split readonly/mutable index types to sub modules #2693

yuja · 2023-12-12T12:51:35Z

Checklist

If applicable:

I have updated CHANGELOG.md
I have updated the documentation (README.md, docs/, demos/)
I have updated the config schema (cli/src/config-schema.json)
I have added tests to cover my changes

Added pub(super) where needed or makes sense.

…er) field into_segment() could be added instead of save_in(), but I decided to wrap save_in(). save_in() may squash ancestor files, so it could be considered an index-level operation.

Added pub(super) where needed. There are a few pub(super) fields that look suspicious, which will be fixed by the subsequent patches.

We could add Layout struct holding these parameters, but I don't think that's needed just for two parameters.

…per) field

yuja added 8 commits December 12, 2023 10:30

index: split mutable index types to "mutable" module

f5f6098

Added pub(super) where needed or makes sense.

index: add wrapper functions to DefaultMutableIndex to remove pub(sup…

4d2a361

…er) field into_segment() could be added instead of save_in(), but I decided to wrap save_in(). save_in() may squash ancestor files, so it could be considered an index-level operation.

index: split readonly index types to "readonly" module

7cb1778

Added pub(super) where needed. There are a few pub(super) fields that look suspicious, which will be fixed by the subsequent patches.

index: use segment_parent_file() instead of direct field access

a0fa4be

index: use name() instead of direct field access

39b9e41

index: use as_composite().num_commits() instead of direct field access

355fb2d

index: add methods that provides commit/change_id_length

73d3042

We could add Layout struct holding these parameters, but I don't think that's needed just for two parameters.

index: add wrapper functions to DefaultReadonlyIndex to remove pub(su…

34bf76a

…per) field

martinvonz approved these changes Dec 12, 2023

View reviewed changes

yuja merged commit 2abbb63 into jj-vcs:main Dec 12, 2023
15 checks passed

yuja deleted the push-nvvntqnwnouz branch December 12, 2023 23:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

index: split readonly/mutable index types to sub modules #2693

index: split readonly/mutable index types to sub modules #2693

yuja commented Dec 12, 2023

index: split readonly/mutable index types to sub modules #2693

index: split readonly/mutable index types to sub modules #2693

Conversation

yuja commented Dec 12, 2023

Checklist