Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index: split DefaultIndexStore, CompositeIndex, and RevWalk to sub modules #2689

Merged
merged 5 commits into from
Dec 11, 2023
Merged

index: split DefaultIndexStore, CompositeIndex, and RevWalk to sub modules #2689

merged 5 commits into from
Dec 11, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Dec 11, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 5 commits December 11, 2023 23:18
@yuja
index: move default_index_store.rs to sub directory named default_index
e40f0f0 
default_index_store.rs is relatively big, and it contains types and impls in
arbitrary order. Let's split them into sub modules. After everything moved,
mod.rs will only contain tests.
@yuja
index: split DefaultIndexStore and Load/StoreError types to "store" m…
f2eecf2 
…odule

IndexLoadError isn't store-specific, but I think it's better to put I/O
stuff in the store module.
@yuja
index: split CompositeIndex and stats types to "composite" module
b9aa65c 
Added pub(super) where needed or makes sense.
@yuja
index: add CompositeIndex constructor instead of pub(super)-ing field
98cd3e7 
This wouldn't matter, but seemed slightly better.
@yuja
index: split RevWalk types to "rev_walk" module
cbe04dd 
Added pub(super) where needed.
martinvonz
martinvonz approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very easy to review on GitHub, so approving mostly on trust

@yuja yuja merged commit ab2742f into jj-vcs:main Dec 11, 2023
15 checks passed
@yuja yuja deleted the push-lqwkowvmtrkm branch December 11, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz