Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revset: refactor collect_dag_range() and walk_*() helpers #2688

Merged
merged 4 commits into from
Dec 11, 2023
Merged

revset: refactor collect_dag_range() and walk_*() helpers #2688

merged 4 commits into from
Dec 11, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Dec 10, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 4 commits December 10, 2023 14:13
@yuja
index: reimplement collect_dag_range() of revset engine as iterator
025b6b2 
I'm going to remove 'index lifetime from InternalRevset so Revset<'static>
can be easily constructed from DefaultReadonlyIndex. As the first step, this
series removes some lifetime complexity from EvaluationContext methods.

We don't need an descendant iterator API, but it helps to add separate function
to collect into HashSet<IndexPosition> instead of returning a pair of
ordered vec and set.
@yuja
revset: inline collect_dag_range()
221a500
@yuja
revset: inline walk_children()
c2c0c09 
There's only one caller, and we have common code at the call site.
@yuja
revset: inline walk_ancestors()
d0e483b
@yuja yuja merged commit f86b338 into jj-vcs:main Dec 11, 2023
15 checks passed
@yuja yuja deleted the push-lqtrmxztlyzw branch December 11, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz