Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: migrate export_refs() to gix::Repository #2683

Merged
merged 4 commits into from
Dec 9, 2023
Merged

git: migrate export_refs() to gix::Repository #2683

merged 4 commits into from
Dec 9, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Dec 9, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 4 commits December 9, 2023 09:55
@yuja
git: have export_refs() obtain git2::Repository instance from store
a22eb83
@yuja
git: unimplement PartialEq on GitExportError
c36443a 
Gitoxide errors don't implement PartialEq, and I don't think it makes sense
to test equality of InternalGitError objects.
@yuja
git: unimplement PartialEq on FailedRefExportReason
870549f 
Gitoxide errors don't implement PartialEq. We could instead stringify the
errors, but there aren't many callers who expect FailedRefExportReason to
be comparable.
@yuja
git: migrate export_refs() to gix::Repository
3a7012e 
FailedToDelete/Set reasons are boxed because gix error types aren't small.
They could be casted to std::error::Error if needed.
martinvonz
martinvonz approved these changes Dec 9, 2023
View reviewed changes
lib/src/git.rs Show resolved Hide resolved
@yuja yuja merged commit 5f6e28c into jj-vcs:main Dec 9, 2023
15 checks passed
@yuja yuja deleted the push-nomqzrxkotyk branch December 9, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz