Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli editor and pager: Add a comment #2622

Merged
merged 1 commit into from
Nov 23, 2023
Merged

cli editor and pager: Add a comment #2622

merged 1 commit into from
Nov 23, 2023

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Nov 23, 2023

Follows up on be1d952.

The information I added is explained in that commit's description, but I feel like it could reduce confusion for future readers of the code.

@ilyagr ilyagr marked this pull request as ready for review November 23, 2023 06:46
@ilyagr
Copy link
Contributor Author

ilyagr commented Nov 23, 2023

@yuja, let me know if you think this is excessive or if you can think of a better idea of how to make things clearer.

Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, thanks.

cli diff editor: Add a comment

nit: it's not "diff editor" but "editor" and "pager". The diff editor doesn't need a similar change.

Follows up on 13c93d5.

The information I added is explained in that commit's description, but
I feel like it could reduce confusion for future readers of the code.
@ilyagr ilyagr enabled auto-merge (rebase) November 23, 2023 07:29
@ilyagr ilyagr merged commit ea22f90 into jj-vcs:main Nov 23, 2023
15 checks passed
@ilyagr ilyagr changed the title cli diff editor: Add a comment cli editor and pager: Add a comment Nov 23, 2023
@ilyagr ilyagr deleted the comment branch November 23, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants