Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli diff: add short description, more details to jj help #2608

Merged
merged 2 commits into from
Nov 21, 2023
Merged

cli diff: add short description, more details to jj help #2608

merged 2 commits into from
Nov 21, 2023

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Nov 21, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr ilyagr marked this pull request as ready for review November 21, 2023 00:32
thoughtpolice
thoughtpolice previously approved these changes Nov 21, 2023
View reviewed changes
@ilyagr ilyagr dismissed thoughtpolice’s stale review November 21, 2023 01:02

Added another commit

@ilyagr
Copy link
Contributor Author

ilyagr commented Nov 21, 2023

Thanks @thoughtpolice! I added another commit, though, so I think this needs another look.

@ilyagr ilyagr changed the title cli diff: add short description to jj help cli diff: add short description, more details to jj help Nov 21, 2023
yuja
yuja approved these changes Nov 21, 2023
View reviewed changes
cli/src/commands/diff.rs Outdated Show resolved Hide resolved
cli/src/commands/diff.rs Outdated Show resolved Hide resolved
@ilyagr ilyagr enabled auto-merge (rebase) November 21, 2023 04:29
@ilyagr ilyagr merged commit d8df36b into jj-vcs:main Nov 21, 2023
15 checks passed
@ilyagr ilyagr deleted the diffdesc branch November 23, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

@thoughtpolice thoughtpolice thoughtpolice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyagr @thoughtpolice @yuja