watchman: minor code cleanup #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
LGTM, but maybe @arxanas can confirm your description of the last commit.
arxanas
reviewed
Nov 19, 2023
arxanas
approved these changes
Nov 20, 2023
Since the caller wants repo-relative paths, it doesn't make sense to convert them back and forth.
We only need &self.working_copy_path here.
If I understand it, watchman returns changed files and directories, and a directory change doesn't mean we need to scan all files under the directory.
yuja
force-pushed
the
push-nmmwoqzsytsq
branch
from
37220d6 to
100bccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md