sign: Implement storage for digital commit signatures #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necauqua
force-pushed
the
push-ustsxtrlqsrz
branch
2 times, most recently
from
5ff13a6 to
7736b00
Compare
martinvonz
approved these changes
Nov 11, 2023
necauqua
force-pushed
the
push-ustsxtrlqsrz
branch
from
7736b00 to
d6eff57
Compare
Recognize signature metadata from git commit objects, implement a basic version of that for the native backend. Extract the signed data (a commit binary repr without the signature) to be verified later.
necauqua
force-pushed
the
push-ustsxtrlqsrz
branch
from
d6eff57 to
2a3af0f
Compare
|
I've also added (well, re-added, initially it was there) a check that skips re-parsing the commit data if gix did not find the gpgsig header. |
martinvonz
approved these changes
Nov 11, 2023
yuja
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognize signature metadata from git commit objects, implement a basic version of that for the native backend.
Extract the signed data (a commit binary repr without the signature) to be verified later.
Third time's the charm :)
This change would be undoubtedly needed for any signing implementation, so might push it to main to make the diffs of any future changes smaller - trying to push the smallest atomic changes.
This time I'm planning to make the actual signature creation part of signing happen outside of the backend, which seems like an obvious idea, but I thought it would be easier to do the other way then
Checklist
If applicable:
CHANGELOG.md