run: Fix up various things. #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
PhilipMetzger
force-pushed
the
push-twktxtvppzyx
branch
from
ffa9bf6 to
c3cf08a
Compare
martinvonz
reviewed
Nov 8, 2023
PhilipMetzger
force-pushed
the
push-twktxtvppzyx
branch
2 times, most recently
from
ac56056 to
479a559
Compare
PhilipMetzger
force-pushed
the
push-twktxtvppzyx
branch
2 times, most recently
from
123d443 to
0834e91
Compare
|
I'd like to finally land this patch tomorrow, so call for last reviews or nits. |
martinvonz
approved these changes
Nov 25, 2023
PhilipMetzger
force-pushed
the
push-twktxtvppzyx
branch
from
0834e91 to
68ba84d
Compare
Adress the post-merge comments from #2486, which found a doc comment inaccurate and to not blindly ignore `-j 0` which would've worked until now. I've also reduced the default `jobs` size to one, as it's user-visible configuration which determines how many processes should run. Thanks to @necauqua the controversial `unsafe` usage was already removed. I've omitted to change `revisions` from an Vec to a RevisonArg for the moment, as I will keep working on the file anyway.
PhilipMetzger
force-pushed
the
push-twktxtvppzyx
branch
from
68ba84d to
0f587a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adress the post-merge comments from #2486, which found a doc comment inaccurate and to not blindly ignore
-j 0which would've worked until now. I've also reduced the defaultjobssize to one, as it's user-visible configurationwhich determines how many processes should run.
Thanks to @necauqua the controversial
unsafeusage was already removed.I've omitted to change
revisionsfrom an Vec to a RevisonArg for the moment, as I will keep working on the file anyway.Checklist
If applicable:
CHANGELOG.md