Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up concurrent tree diff a bit #2539

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Clean up concurrent tree diff a bit #2539

merged 2 commits into from
Nov 7, 2023

Conversation

martinvonz
Copy link
Member

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@martinvonz
merged_tree: drop outer loop in TreeDiffStreamImpl::poll_next()
f062d32 
As suggested by Yuya. I also added a comment and an assertion in the
case where return `Poll::Pending`.
@martinvonz
merged_tree: extract polling of tree futures into a function
51a5965
@martinvonz martinvonz enabled auto-merge (rebase) November 7, 2023 07:50
yuja
yuja approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinvonz martinvonz merged commit 1140295 into main Nov 7, 2023
15 checks passed
@martinvonz martinvonz deleted the push-mxrnmxxxvxxm branch November 7, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinvonz @yuja