Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website (poetry and mike)-related updates #2532

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Nov 5, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr ilyagr force-pushed the poetry branch 3 times, most recently from 91b7c71 to 84a5a15 Compare November 5, 2023 23:40
@ilyagr ilyagr marked this pull request as ready for review November 5, 2023 23:40
1. Add --no-root to poetry invocations. Poetry 1.7 displays an error otherwise
(though things still work)

https://github.com/orgs/python-poetry/discussions/8622
python-poetry/poetry#1132

2. Document python-poetry/poetry#8623
This is mainly for our own information. It doesn't have to be a required check.
The previous commit checks that Poetry down to version 1.3.2 (current Debian
stable version) support it.
@ilyagr ilyagr changed the title Poetry-related updates Website (poetry and mike)-related updates Nov 6, 2023
@ilyagr ilyagr force-pushed the poetry branch 4 times, most recently from 641d496 to 5362d74 Compare November 6, 2023 00:39
Originally, my motivation was to try again to get `mike` to not push empty
commits (which this should do). I'm now reconsidering this, since *not* pushing
empty commits will make the output of the CI job a little harder to read. If
this becomes an issue, I  might even add `--allow-empty` to the `mike`
invocations later.

A more important motivation is that even for a 400-byte file, changing it for
every PR blows up the size of the repo eventually.

The cause for the changes to this file was that `gzip` stores a timestamp
inside the `.gz` file.
@ilyagr ilyagr merged commit 043f786 into jj-vcs:main Nov 7, 2023
15 checks passed
@ilyagr ilyagr deleted the poetry branch November 7, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants