nix: include darwin deps inside devShell, too
#2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Without `devShell` providing the needed Darwin-specific inputs, `cargo build` does not work inside a `nix develop` or `direnv` environment; libgit2 in particular fails on being able to find the Security framework. The actual `nix build` invocation however *does* work because we correctly include those dependencies in the package `buildInputs`. So just factor them out, and use them in both places. Signed-off-by: Austin Seipp <[email protected]> Change-Id: I484bf381ca31c29c4c39fb6d184bdd21
Ralith
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Without
devShellproviding the needed Darwin-specific inputs,cargo builddoes not work inside anix developordirenvenvironment; libgit2 in particular fails on being able to find the Security framework.The actual
nix buildinvocation however does work because we correctly include those dependencies in the packagebuildInputs. So just factor them out, and use them in both places.Change-Id: I484bf381ca31c29c4c39fb6d184bdd21