Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: upgrade mike to version 2.0 #2523

Merged
merged 1 commit into from
Nov 4, 2023
Merged

website: upgrade mike to version 2.0 #2523

merged 1 commit into from
Nov 4, 2023

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Nov 4, 2023

https://github.com/jimporter/mike/releases/tag/v2.0.0

The main immediate advantage of this is that mike will stop pushing empty commits.

Also, we can consider switching to using symlinks instead of redirects for mapping the "latest" version to "v0.11.0". This would make https://martinvonz.github.io/jj/latest/ have the same content as https://martinvonz.github.io/jj/v0.11.0/ (until the next version is out), but the user would see latest in the URL.

For now, I set an option to keep using redirects.

I did a bit of non-exhaustive testing; it seems to work.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr ilyagr marked this pull request as ready for review November 4, 2023 05:39
@ilyagr ilyagr force-pushed the mike branch 3 times, most recently from 08951c2 to 25b7476 Compare November 4, 2023 06:15
https://github.com/jimporter/mike/releases/tag/v2.0.0

The main immediate advantage of this is that `mike` will stop pushing empty
commits.

Also, we can consider switching to using symlinks instead of redirects for
mapping the "latest" version to "v0.11.0". This would make
`https://martinvonz.github.io/jj/latest/` have the same content as
`https://martinvonz.github.io/jj/v0.11.0/` (until the next version is out), but
the user would see `latest` in the URL.

For now, I set an option to keep using redirects.

I did a bit of non-exhaustive testing; it seems to work.
@ilyagr ilyagr merged commit 5fc649c into jj-vcs:main Nov 4, 2023
14 checks passed
@ilyagr ilyagr deleted the mike branch November 4, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants