Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move initialization of colocated git repo to lib #2522

Merged
merged 5 commits into from
Nov 4, 2023
Merged

move initialization of colocated git repo to lib #2522

merged 5 commits into from
Nov 4, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Nov 4, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 5 commits November 4, 2023 12:15
@yuja
workspace: fix repository path in init_internal_git() doc comment
7a2e15c 
Also rephrased "Git backend" as "Git repo" since the new backend storage will
be created.
@yuja
workspace: one less cloning of workspace_root in init_external_git()
21ce19b 
Just a trivial code cleanup.
@yuja
git_backend: extract inner function that initializes backend with ope…
c8e2e61 
…n git repo
@yuja
tests: assert paths of initialized GitBackend
71ec971
@yuja
workspace: add function that initializes colocated git repository
b9cc2ac 
One less git2 API use in CLI.

The function name GitBackend::init_colocated() is a bit odd, but we need to
specify the work-tree path, not the ".git" repo path. So we can't eliminate
the notion of the working copy path anyway.
thoughtpolice
thoughtpolice approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and happy to see less libgit2 usage.

lib/src/git_backend.rs Show resolved Hide resolved
@yuja yuja merged commit 602b442 into jj-vcs:main Nov 4, 2023
14 checks passed
@yuja yuja deleted the push-skxrrztxpznu branch November 4, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuja @thoughtpolice @martinvonz