Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MkDocs work with more GitHub-like list formatting, poetry updates #2516

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Nov 3, 2023

The motivation here was to make the word formatting I recently introduced to revsets.md less weird, and to make it more likely that markdown that renders fine on GitHub also renders reasonably by MkDocs.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr ilyagr marked this pull request as ready for review November 3, 2023 05:29
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. I don't have much expertise on mkdocs, but the change looks good to me.

docs/revsets.md Show resolved Hide resolved
docs/sapling-comparison.md Outdated Show resolved Hide resolved
This adds two MkDocs extensions to make list handling more flexible.
It took some trial-and-error, but it seems this config works OK.

revsets.md: use saner formatting that is now possible.

sapling-comparison.md: this was the one case I saw made worse by the
new plugins. I changed the Markdown formatting, it still looks sane.
Considering the previous commit, it's unclear how compatible we are
with previous mkdocs-material versions.
@ilyagr ilyagr enabled auto-merge (rebase) November 4, 2023 02:05
@ilyagr ilyagr merged commit e701b08 into jj-vcs:main Nov 4, 2023
14 checks passed
@ilyagr ilyagr deleted the lists branch November 4, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants