cli: support multiple --revision arguments to workspace add
#2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
reviewed
Nov 3, 2023
thoughtpolice
force-pushed
the
aseipp/push-vruxzunvwysq
branch
3 times, most recently
from
0165324 to
01a209a
Compare
martinvonz
approved these changes
Nov 3, 2023
thoughtpolice
force-pushed
the
aseipp/push-vruxzunvwysq
branch
from
01a209a to
71ee2e9
Compare
|
I also included a small refactoring on top. |
thoughtpolice
force-pushed
the
aseipp/push-vruxzunvwysq
branch
from
71ee2e9 to
2622663
Compare
martinvonz
reviewed
Nov 3, 2023
thoughtpolice
force-pushed
the
aseipp/push-vruxzunvwysq
branch
2 times, most recently
from
acf8750 to
41a264c
Compare
Summary: A natural extension of the existing support, as suggested by Scott Olson. Closes #2496. Signed-off-by: Austin Seipp <[email protected]> Change-Id: I91c9c8c377ad67ccde7945ed41af6c79
Summary: This is currently used by `new.rs`, `workspace.rs`, and `rebase.rs`, and may be useful for other commands and custom CLIs. So just go ahead and move it into the parent module hierarchy. Also rename the function to `resolve_all_revs`, as it isn't actually specific to rebase at all. Signed-off-by: Austin Seipp <[email protected]> Change-Id: I0ea12afd8107f95a37a91340820221a0
thoughtpolice
force-pushed
the
aseipp/push-vruxzunvwysq
branch
from
41a264c to
962507c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: A natural extension of the existing support, as suggested by Scott Olson. Closes #2496.
Change-Id: I91c9c8c377ad67ccde7945ed41af6c79
Checklist
If applicable:
CHANGELOG.md