Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: fix the rustfmt version by using nightly #2508

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

thoughtpolice
Copy link
Member

Summary: Apparently this was broken. Maybe I broke it. Maybe something upstream changed and caused a regression. But without it, we get the stable rustfmt in the nix develop shell environment, not the nightly version. Fix it.

Change-Id: I602ed8e5691c4d48f8db575d62624955

@thoughtpolice thoughtpolice self-assigned this Nov 3, 2023
Summary: Apparently this was broken. Maybe I broke it. Maybe something upstream
changed and caused a regression. But without it, we get the stable `rustfmt` in
the `nix develop` shell environment, not the nightly version. Fix it.

Signed-off-by: Austin Seipp <[email protected]>
Change-Id: I602ed8e5691c4d48f8db575d62624955
@thoughtpolice thoughtpolice force-pushed the aseipp/push-tsqwmspnvqos branch from 4b834ae to f5c6fe8 Compare November 3, 2023 00:57
@thoughtpolice thoughtpolice changed the title nix: fix the rustfmt version, use correct nightly @thoughtpolice nix: fix the rustfmt version by using nightly Nov 3, 2023
@thoughtpolice thoughtpolice changed the title @thoughtpolice nix: fix the rustfmt version by using nightly nix: fix the rustfmt version by using nightly Nov 3, 2023
@thoughtpolice thoughtpolice enabled auto-merge (rebase) November 3, 2023 00:57
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using unstable rustfmt with stable rustc anyway?

@thoughtpolice thoughtpolice merged commit 4a6ebd0 into main Nov 4, 2023
14 checks passed
@thoughtpolice thoughtpolice deleted the aseipp/push-tsqwmspnvqos branch November 4, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants