Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: fix codespell skip syntax for directories #2505

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

thoughtpolice
Copy link
Member

Summary: Codespell actually matches local files at the root of the repo with the ./ prefix, so without it the skip field won't match. Fix this for ./target and ./.jj directories.

Change-Id: Ibeafd7e400ff3bca9187d62241296060

@thoughtpolice thoughtpolice self-assigned this Nov 2, 2023
Summary: Codespell actually matches local files at the root of the repo with the
`./` prefix, so without it the `skip` field won't match. Fix this for `./target`
and `./.jj` directories.

Signed-off-by: Austin Seipp <[email protected]>
Change-Id: Ibeafd7e400ff3bca9187d62241296060
@thoughtpolice thoughtpolice force-pushed the aseipp/push-unnkvoylqowl branch from 0ecb45b to e4b32d5 Compare November 2, 2023 16:45
@thoughtpolice thoughtpolice changed the title github: fix codespell 'skip' syntax for directories github: fix codespell skip syntax for directories Nov 2, 2023
@thoughtpolice thoughtpolice enabled auto-merge (rebase) November 2, 2023 16:45
Copy link
Contributor

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that there ends up being a ./.jj directory at all in the GitHub Actions workflow, though — do we create one at some point?

@thoughtpolice thoughtpolice merged commit 37d6e71 into main Nov 2, 2023
14 checks passed
@thoughtpolice thoughtpolice deleted the aseipp/push-unnkvoylqowl branch November 2, 2023 20:37
@thoughtpolice
Copy link
Member Author

I'm surprised that there ends up being a ./.jj directory at all in the GitHub Actions workflow, though — do we create one at some point?

No, but I just kept it there because shrug. Seems like it's been there since the beginning; see 615862d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants