revsets.md: clarify string patterns, and file patterns #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinvonz or @yuja, please check for correctness. I had to experiment a bit to get what I think are the correct rules. In particular, I can't think of a situation where quotes are not optional, but maybe there is some or we want to deprecate it? (It's awfully convenient to do |
ilyagr
force-pushed
the
strpat
branch
2 times, most recently
from
9453984 to
984520a
Compare
ilyagr
changed the title
ilyagr
force-pushed
the
strpat
branch
3 times, most recently
from
e588189 to
fccb77e
Compare
|
I seem to have gotten it wrong, it's ~fixed now. I can also postpone documenting the current |
ilyagr
force-pushed
the
strpat
branch
6 times, most recently
from
2f442e6 to
8057f0e
Compare
|
The indentation change is not very pretty, but making it more consistent would require some trial and error with what both MkDocs and GitHub accept. |
martinvonz
approved these changes
Oct 31, 2023
ilyagr
force-pushed
the
strpat
branch
3 times, most recently
from
58532c9 to
9c1e294
Compare
I had to increase indent on two list items for multiple paragraphs to work in MkDocs.
|
Thanks, Yuya and Martin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to increase indent on two list items for multiple paragraphs to work in
MkDocs.
Checklist
If applicable:
CHANGELOG.md