Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands move backout code to backout rs #2441

Conversation

AntoineCezar
Copy link
Contributor

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@martinvonz
Copy link
Member

IIUC, this PR should ideally be based on #2440. GitHub unfortunately doesn't let you base a PR on a branch in another repo (yours in this case). I've invited you as collaborator so you can push directly to my repo and set up the base branches correctly in the future. For this round of PRs, let's just merge them one at a time. So once this one has been merged, you'll have to rebase your branch and push again, and then we can merge the next PR.

@martinvonz
Copy link
Member

Or we can just review the last PR in the stack and merge that. Let us know what you prefer.

@AntoineCezar AntoineCezar force-pushed the commands_move_backout_code_to_backout_rs branch from f81d6a7 to 9814aa8 Compare October 27, 2023 18:02
@AntoineCezar
Copy link
Contributor Author

I'll keep the last pr since I'll be forced to close the other anyway if I want to push in this repo.

@AntoineCezar AntoineCezar deleted the commands_move_backout_code_to_backout_rs branch October 28, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants