git: on import_refs(), don't abandon ancestors of newly fetched refs #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made import_refs() not preserve commits referenced by remote branches at 520f692 "git: on import_refs(), don't preserve old branches referenced by remote refs." The idea is that remote branches are weak, and commits referenced by these refs can be freely rewritten by future local changes without moving the refs. I don't think that's wrong, but 520f692 also made "new" remote changes be abandoned by old remote refs. This problem occurs only when git.auto-local-branch is off. I think there are two ways to fix the problem: a. pin non-tracking remote branches just like local refs b. pin newly fetched refs in addition to local refs This patch implements (b) because it's simpler and more obvious that the fetched commits would never be abandoned immediately.
martinvonz
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md