-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add nushell completion support #2353
Conversation
ef5fa7f
to
e4d228b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks good to me. Feel free to mark it as ready and merge it.
One minor thing is that the nix flake app installs completions for the three shells automatically, and I've no idea about nushell support in nix/nixos I guess somebody who uses both (nix and nushell, that is) will come along to fix that eventually |
I do use nix and I'm trying to move to nushell, but afaik there is no "standard way" for nushell completion files in nix |
@NyCodeGHG, are you planning to make any changes to this PR? |
No, only clap_complete_nushell needs to be updated once clap-rs/clap#5165 is fixed |
Ah, I missed that bit. I agree with waiting until we can depend on a fixed version of |
Yeah, I'm actually checking out nushell now, and yeah there's no support in nix as of now For future reference, once |
Any updates on this? |
still blocked by clap_complete_nushell generating invalid code |
I've made #3073 and the fix upstream to handle nushell completions |
superseded by #3073 |
This PR adds nushell completion support, see #2323
because of clap-rs/clap#5164, this generates invalid nu code for now
Checklist
If applicable:
CHANGELOG.md