Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: discuss jj commit -i in FAQ.md #2312

Merged
merged 1 commit into from
Oct 22, 2023
Merged

docs: discuss jj commit -i in FAQ.md #2312

merged 1 commit into from
Oct 22, 2023

Conversation

arxanas
Copy link
Contributor

@arxanas arxanas commented Oct 1, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@arxanas arxanas marked this pull request as ready for review October 1, 2023 02:53
@arxanas arxanas mentioned this pull request Oct 1, 2023
Merged
4 tasks
Base automatically changed from arxanas/commit-3 to main October 1, 2023 03:03
martinvonz
martinvonz reviewed Oct 1, 2023
View reviewed changes
docs/faq.md Outdated Show resolved Hide resolved
ilyagr
ilyagr reviewed Oct 2, 2023
View reviewed changes
docs/faq.md Outdated Show resolved Hide resolved
@arxanas arxanas force-pushed the arxanas/faq branch 2 times, most recently from 68f0e75 to 8801459 Compare October 3, 2023 05:19
@ilyagr ilyagr mentioned this pull request Oct 4, 2023
Merged
@arxanas arxanas enabled auto-merge (rebase) October 14, 2023 19:34
@arxanas arxanas changed the title FAQ updates docs: discuss jj commit -i in FAQ.md Oct 14, 2023
@arxanas arxanas mentioned this pull request Oct 17, 2023
Open
arxanas
arxanas commented Oct 17, 2023
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
martinvonz
martinvonz approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks.

@arxanas arxanas merged commit aacad9d into main Oct 22, 2023
14 checks passed
@arxanas arxanas deleted the arxanas/faq branch October 22, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipMetzger PhilipMetzger PhilipMetzger left review comments

@ilyagr ilyagr ilyagr left review comments

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arxanas @martinvonz @ilyagr @PhilipMetzger